Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distro selection docs #2788

Closed
wants to merge 2 commits into from

Conversation

jeremydvoss
Copy link

Updating website docs for auto instrumentation with respect this this pr: open-telemetry/opentelemetry-python-contrib#1823

Comment on lines +31 to +36
- `distro` specifies which distro should be loaded. Argument should be the entry
point name of the desired distro. If only a single distro exists, this
argument may be left out.
- `configurator` specifies which configurator should be loaded. Argument should
be the entry point name of the desired configurator. If only a single
configurator exists, this argument may be left out.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for someone who is not involved with the python SIG I have no idea what this should mean. What other distros are there available? What is the difference here? Are we talking about vendor-specific distros or something else?

Same for the configurator, what options to I have and why would I choose another one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 even as someone involved I don't remember what distro vs configurator is. Would be nice to have something explaining what they are.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have documentation (at least for distros) here. I'm not sure this is the place where we should document what a distro or a configurator is. We don't do any explanation for --traces_exporter or --metrics_exporter either.

Maybe just a link to the general documentation would be enough here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always found the distros page you linked confusing because it replicates a lot of what is written in the automatic documentation, so we need to merge them eventually. Also, Python is the only language as far as I am aware that has this understanding of a distribution.

I have no issue with distro and configurator being documented as outlined here, but what we need is examples what options I have as an enduser, if there are currently only 1 option and they will come later, then let's postpone this for now and add it when people have a choise.

We don't do any explanation for --traces_exporter or --metrics_exporter either.

We could have them.

@cartermp
Copy link
Contributor

The other thing is that I don't like having to list out all of these options unless necessary. Are there defaults (like distro) that will be there when unspecified?

@chalin chalin force-pushed the distro-selection branch from bbaa0d4 to ebfc86c Compare June 6, 2023 15:46
@svrnm
Copy link
Member

svrnm commented Jun 9, 2023

@open-telemetry/python-maintainers / @open-telemetry/python-approvers I leave it to you if/when we add this to the docs, please provide guidance

@chalin chalin force-pushed the distro-selection branch from 78b7383 to eb7c3f9 Compare June 9, 2023 11:26
@jeremydvoss
Copy link
Author

The other thing is that I don't like having to list out all of these options unless necessary. Are there defaults (like distro) that will be there when unspecified?

Yes the base distro that can also be referred to as the "distro" entry point is the default.

@chalin chalin force-pushed the distro-selection branch from eb7c3f9 to e8777b5 Compare June 9, 2023 21:24
@cartermp
Copy link
Contributor

@jeremydvoss sorry, I'm not sure I understand. Is the option --distro a required parameter when running the autoinstrumentation agent?

@cartermp
Copy link
Contributor

cartermp commented Nov 4, 2023

Closing due to inactivity

@cartermp cartermp closed this Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants