Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitpod minimal config #1629

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Aug 17, 2022

@chalin chalin requested review from cartermp and a team August 17, 2022 21:51
@chalin chalin mentioned this pull request Aug 17, 2022
# Gitpod config. For details, see https://www.gitpod.io/docs/config-gitpod-file.

tasks:
- init: npm install && npm run check-links
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good to also use npm run serve so that folks can have a dev version of the site built and running in their environment. But I'm also fine if that's not included.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My preference would be to first commit this minimal version and then we can experiment and grow it over time. Thanks for the review and approval. Will merge this now as is.

@chalin chalin merged commit 1f8c41f into open-telemetry:main Aug 17, 2022
@chalin chalin deleted the chalin-gp-gitpod-yml-2022-08-17 branch August 17, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants