All schema files are returning 404 #1846
Comments
|
This is a critical bug that needs a quick fix and we need automated tests to prevent this from happening again. |
|
@open-telemetry/docs-approvers can someone help with this? I am not sure when exactly did we break this. |
|
The publishing of schema files was previously automated in #715 |
|
@chalin would have the most context here. |
|
ok. the following versions work: 1.10.0 1.11.0 1.12.0 1.4.0 1.5.0 1.6.1 1.7.0 1.8.0 1.9.0 |
|
looks like the spec version has not been upgraded for 1.13 and 1.14. git submodule version is at |
This downloads the schema files from https://opentelemetry.io/schemas/ and verifies their content. Next time we make a release this will force us to make sure https://github.com/open-telemetry/opentelemetry.io repo is updated before we make the release. This helps prevent issues like open-telemetry/opentelemetry.io#1846
|
@svrnm will you fix it or want me to take a look at this? |
I tried it but tbh my git skills are not advanced enough: I tried to pull the 1.14 commit in the Submodule and not HEAD but couldn’t figure it out So if you know how that would be appreciated |
|
Let me try. |
|
Hi all. I'll be back at my desk in about 15 min. I can give it a try then if you'd like. Let me know. |
|
Ok, back. Btw, there are some extra issues to be dealt with -- see #1495. I can address all of those in one go. |
Please do and ping me when done so that I can re-run the verification job on the spec repo: open-telemetry/opentelemetry-specification#2868 |
|
@tigrannajaryan - I'm on it. The spec has changed, resulting in broken links, so I'm fixing that now. |
|
@tigrannajaryan et al.: the PR is ready for review |
@tigrannajaryan - I don't see any 1.7.1 schema under https://github.com/open-telemetry/opentelemetry-specification/tree/main/schemas. Did you mean 1.6.1? |
|
The new spec is live. If you would like any further changes, let me know and I'll include them in a followup PR. |
To clarify: the schema files get published once the spec content-module is updated. The update of the spec isn't automated since it usually requires manual intervention, such as fixing broken links into the spec pages. |
My mistake. I was looking for a schema that never existed. |
This downloads the schema files from https://opentelemetry.io/schemas/ and verifies their content. Next time we make a release this will force us to make sure https://github.com/open-telemetry/opentelemetry.io repo is updated before we make the release. This helps prevent issues like open-telemetry/opentelemetry.io#1846 Also add release procedure to the docs.
This downloads the schema files from https://opentelemetry.io/schemas/ and verifies their content. Next time we make a release this will force us to make sure https://github.com/open-telemetry/opentelemetry.io repo is updated before we make the release. This helps prevent issues like open-telemetry/opentelemetry.io#1846 Also add release procedure to the docs.
This downloads the schema files from https://opentelemetry.io/schemas/ and verifies their content. Next time we make a release this will force us to make sure https://github.com/open-telemetry/opentelemetry.io repo is updated before we make the release. This helps prevent issues like open-telemetry/opentelemetry.io#1846 Also add release procedure to the docs.
This downloads the schema files from https://opentelemetry.io/schemas/ and verifies their content. Next time we make a release this will force us to make sure https://github.com/open-telemetry/opentelemetry.io repo is updated before we make the release. This helps prevent issues like open-telemetry/opentelemetry.io#1846 Also add release procedure to the docs.
This downloads the schema files from https://opentelemetry.io/schemas/ and verifies their content. Next time we make a release this will force us to make sure https://github.com/open-telemetry/opentelemetry.io repo is updated before we make the release. This helps prevent issues like open-telemetry/opentelemetry.io#1846 Also add release procedure to the docs.
What happened?
The schema file URLs that used to work are now returning 404. E.g. https://opentelemetry.io/schemas/1.7.1 or https://opentelemetry.io/schemas/1.14.0
What did you expect would happen?
It should be a 200 and return the content of relevant file from https://github.com/open-telemetry/opentelemetry-specification/tree/main/schemas
What is the name + path of the page where you encountered the issue?
https://opentelemetry.io/schemas/*What browser, OS, and platform were you using when you encountered the problem?
Chrome Version 105.0.5195.125 (Official Build) (x86_64), Mac OS 12.5
The text was updated successfully, but these errors were encountered: