Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add baggage span processor #673

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

martin308
Copy link
Contributor

Adds a baggage span processor as per the other contrib repositories.

This processor takes items from the baggage and adds the items as attributes on spans.

Eg. open-telemetry/opentelemetry-go-contrib#5404

@martin308
Copy link
Contributor Author

The macOS tests look like they might be flaky but the linux test result is for my new tests will poke around and try to find the cause

Copy link
Member

@nachoBonafonte nachoBonafonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change it to a more expressible naming, it looks very generic like this
It also would need proper documentation in the source code for the future users, for the rest it LGTM

@martin308
Copy link
Contributor Author

From the sync, naming wise we will go BaggagePropagationProcessor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants