Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracers should reference an InstrumentationLibrary rather than a Resource #616

Merged
merged 1 commit into from
May 21, 2020
Merged

Tracers should reference an InstrumentationLibrary rather than a Resource #616

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions specification/trace/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,18 +143,19 @@ TODO: Split out the parent handling.
## Tracer Creation

New `Tracer` instances are always created through a `TracerProvider` (see
[API](api.md#obtaining-a-tracer)). The `name` and `version` arguments
supplied to the `TracerProvider` must be used to create a
[`Resource`](../resource/sdk.md) instance which is stored on the created `Tracer`.
[API](api.md#obtaining-a-tracer)). The `name` and `version` arguments
supplied to the `TracerProvider` must be used to create an
[`InstrumentationLibrary`][otep-83] instance which is stored on the created
`Tracer`.

All configuration objects (SDK specific) and extension points (span processors,
propagators) must be provided to the `TracerProvider`. `Tracer` instances must
not duplicate this data (unless for read-only access) to avoid that different
`Tracer` instances of a `TracerProvider` have different versions of these data.

The readable representations of all `Span` instances created by a `Tracer` must
provide a `getLibraryResource` method that returns this `Resource` information
held by the `Tracer`.
provide a `getInstrumentationLibrary` method that returns the
`InstrumentationLibrary` information held by the `Tracer`.

## Span processor

Expand Down Expand Up @@ -407,3 +408,4 @@ public interface SpanExporter {
```

[trace-flags]: https://www.w3.org/TR/trace-context/#trace-flags
[otep-83]: https://github.com/open-telemetry/oteps/blob/master/text/0083-component.md