Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes of typos in trace/{sdk,api}.md #4216

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

yuanyuanzhao3
Copy link
Contributor

Changes

Fixes a few typos in the specifications.

@yuanyuanzhao3 yuanyuanzhao3 requested review from a team as code owners September 19, 2024 02:19
Copy link

linux-foundation-easycla bot commented Sep 19, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@reyang
Copy link
Member

reyang commented Sep 19, 2024

Thanks @yuanyuanzhao3! Would you clear the CLA #4216 (comment)?

@reyang reyang added the editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. label Sep 19, 2024
@yuanyuanzhao3
Copy link
Contributor Author

Thanks @yuanyuanzhao3! Would you clear the CLA #4216 (comment)?

done.

@yuanyuanzhao3
Copy link
Contributor Author

can someone approve the workflow run? thanks.

@yuanyuanzhao3
Copy link
Contributor Author

I'm also not allowed to merge. I guess I'm too new. Please let me know if there anything I missed. Thanks.

@reyang reyang merged commit 213b919 into open-telemetry:main Sep 19, 2024
6 checks passed
@cijothomas
Copy link
Member

I'm also not allowed to merge. I guess I'm too new. Please let me know if there anything I missed. Thanks.

No worries. Only maintainers of this repo can do the merging. Unless there are open conversations/request-for-changes, this is typically merged in couple days. This one is editorial, so likely much faster!
https://github.com/open-telemetry/opentelemetry-specification/blob/main/CONTRIBUTING.md#how-to-get-your-pr-merged

@reyang
Copy link
Member

reyang commented Sep 19, 2024

I'm also not allowed to merge. I guess I'm too new. Please let me know if there anything I missed. Thanks.

No worries. Only maintainers of this repo can do the merging. Unless there are open conversations/request-for-changes, this is typically merged in couple days. This one is editorial, so likely much faster! https://github.com/open-telemetry/opentelemetry-specification/blob/main/CONTRIBUTING.md#how-to-get-your-pr-merged

Faster than your comment @cijothomas 😆

@cijothomas
Copy link
Member

Concurrent, not parallel 😄

@yuanyuanzhao3
Copy link
Contributor Author

Thanks everyone. That marked my first PR in OTel. Small but it's a start.

Copy link
Contributor

@jmacd jmacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yuanyuanzhao3!

carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants