Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional resource attributes for browser #3287

Closed

Conversation

scheler
Copy link
Contributor

@scheler scheler commented Mar 3, 2023

Changes

Additional resource attributes for browser based on discussions in the Client-side-telemetry SIG.

@scheler scheler requested review from a team March 3, 2023 21:04
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 12, 2023
This will remain same in a given browser session, and will persist
across page navigations in the same browser session.
examples: ["123"]
- id: session_id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is the correct location / name for this value as the session id could be used for more than the browser.

Additionally, as a varying attribute I'm not sure that this is location -- but I don't know where this belongs.

@@ -54,3 +54,34 @@ groups:
to retrieve brands and platform individually from the User-Agent Client Hints API.
To retrieve the value, the legacy `navigator.userAgent` API can be used.
examples: ['Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/95.0.4638.54 Safari/537.36']
- id: visitor_id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in the RUM Sig this morning, to avoid possible duplication between client runtimes (browser, android, IOS, IOT, etc) perhaps these should be defined with a more generic namespace.

Perhaps: client (need to check if there is an ECS equivalent to avoid possible name clashes if/when ECS merges)

Additionally, as several of these are defined as varying values within a single execution resources may also not be the best location for these types.

@tedsuo do you have any thoughts on where to define semantic conventions for mutable resource values (ie. Ephemeral Resource type Attributes )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I raised a separate issue #3351 seeking guidance on a common namespace for browser and mobile.

@github-actions
Copy link

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Mar 22, 2023
@scheler
Copy link
Contributor Author

scheler commented Mar 28, 2023

@open-telemetry/specs-approvers can someone please re-open this PR? It got closed due to inactivity but I plan to work on it further now. Thanks

@lmolkova lmolkova reopened this Mar 28, 2023
@github-actions github-actions bot removed the Stale label Mar 29, 2023
@arminru arminru added area:semantic-conventions Related to semantic conventions spec:resource Related to the specification/resource directory enhancement New feature or request labels Mar 29, 2023
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Apr 7, 2023
@github-actions
Copy link

Closed as inactive. Feel free to reopen if this PR is still being worked on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions enhancement New feature or request spec:resource Related to the specification/resource directory Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants