Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[semantic_conventions/resource] fix google platform openshift naming #3095

Merged
merged 4 commits into from
Jan 23, 2023
Merged

[semantic_conventions/resource] fix google platform openshift naming #3095

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0886946
[semantic_conventions/resource] fix google platform openshift naming
frzifus Jan 11, 2023
93e3fee
changelog: fix linting
frzifus Jan 13, 2023
8dd6792
Merge branch 'main' into fix_openshift_platform_name
frzifus Jan 16, 2023
e1dec1f
Merge branch 'main' into fix_openshift_platform_name
reyang Jan 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ release.

- Add `code.lineno` source code attribute
([#3029](https://github.com/open-telemetry/opentelemetry-specification/pull/3029))
- Rename google openshift platform attribute from `google_cloud_openshift` to `gcp_openshift`
to match the existing `cloud.provider` prefix.
[#3095](https://github.com/open-telemetry/opentelemetry-specification/pull/3095)

### Compatibility

Expand Down
4 changes: 2 additions & 2 deletions semantic_conventions/resource/cloud.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,8 @@ groups:
- id: gcp_app_engine
value: 'gcp_app_engine'
brief: Google Cloud App Engine (GAE)
- id: google_cloud_openshift
value: 'google_cloud_openshift'
- id: gcp_openshift
value: 'gcp_openshift'
brief: Red Hat OpenShift on Google Cloud
- id: ibm_cloud_openshift
value: 'ibm_cloud_openshift'
Expand Down
2 changes: 1 addition & 1 deletion specification/resource/semantic_conventions/cloud.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
| `gcp_kubernetes_engine` | Google Cloud Kubernetes Engine (GKE) |
| `gcp_cloud_functions` | Google Cloud Functions (GCF) |
| `gcp_app_engine` | Google Cloud App Engine (GAE) |
| `google_cloud_openshift` | Red Hat OpenShift on Google Cloud |
| `gcp_openshift` | Red Hat OpenShift on Google Cloud |
| `ibm_cloud_openshift` | Red Hat OpenShift on IBM Cloud |
| `tencent_cloud_cvm` | Tencent Cloud Cloud Virtual Machine (CVM) |
| `tencent_cloud_eks` | Tencent Cloud Elastic Kubernetes Service (EKS) |
Expand Down