Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add process.disk.operations metric to semantic conventions #2845

Closed
wants to merge 1 commit into from
Closed

Add process.disk.operations metric to semantic conventions #2845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ release.
([#2874](https://github.com/open-telemetry/opentelemetry-specification/pull/2874))
- Add `process.paging.faults` metric to semantic conventions
([#2827](https://github.com/open-telemetry/opentelemetry-specification/pull/2827))
- Add `process.disk.operations` metric to semantic conventions
([#2845](https://github.com/open-telemetry/opentelemetry-specification/pull/2845))

### Compatibility

Expand Down
1 change: 1 addition & 0 deletions specification/metrics/semantic_conventions/process-metrics.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ Below is a table of Process metric instruments.
| `process.memory.usage` | UpDownCounter | By | The amount of physical memory in use. | |
| `process.memory.virtual` | UpDownCounter | By | The amount of committed virtual memory. | |
| `process.disk.io` | Counter | By | Disk bytes transferred. | `direction` SHOULD be one of: `read`, `write` |
| `process.disk.operations` | Counter | {operations} | Number of disk operations performed by the process | `direction` SHOULD be one of: `read`, `write` |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about "control" (e.g. seek, S.M.A.R.T. signal)?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how this is inline with process.disk.io, w/ direction being either read or write. I suspect SMART capabilities would need their own metric(s). I don't how to address seek.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are lots and back-and-forth, e.g. #2617.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reyang I do recognize that this has been a much-discussed topic:

The current state is that metrics very similar to the proposed process.disk.operations metric exist in the semantic conventions in the same shape as the proposed metric (with the "direction" attribute of either "read" or "write"):

This proposal adds the process.disk.operations metric that is related to process.disk.io in the same was that the system.disk.operations is related to system.disk.io metric. I believe this is not a controversial change and there's no reason to not add this metric in the current shape.

If you want the discuss the shape of these metrics, I'd say it's better to open a separate issue.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is not a controversial change and there's no reason to not add this metric in the current shape.

I have different understanding - we already know the existing ones are wrong and will take breaking changes before they can be marked stable, it'll be better to avoid adding more things that require a fix.

| `process.network.io` | Counter | By | Network bytes transferred. | `direction` SHOULD be one of: `receive`, `transmit` |
| `process.threads` | UpDownCounter | {threads} | Process threads count. | |
| `process.open_file_descriptors` | UpDownCounter | {count} | Number of file descriptors in use by the process. | |
Expand Down