Revert #2617, #2675, #2688: "add metrics to replace metrics with direction"
#2748
Conversation
|
Please review this carefully. It is not an automatic reverting, I had to fix merge conflicts manually and may have made mistakes, so a thorough review is needed. |
|
@open-telemetry/specs-approvers this blocks the release. Please review. |
arminru
added
area:semantic-conventions
|
Note that this does not revert #2675 which I believe to still be valid. If you think otherwise please speak. |
@tigrannajaryan But looks like you already revert it . See here, |
Good catch. I did not intend to, fixed now. However, now that I go over #2675 again I wonder if it should be reverted. @open-telemetry/specs-approvers please tell what do you think we should do. Should #2675 also be reverted for now? Do we feel confident that it was right to split |
tigrannajaryan
force-pushed
the
feature/tigran/revert-2617
branch
from
08155f6 to
ca5a14f
Compare
|
@open-telemetry/specs-metrics-approvers please review. |
tigrannajaryan
force-pushed
the
feature/tigran/revert-2617
branch
from
ca5a14f to
b2e4e3a
Compare
|
@tigrannajaryan I'm slightly inclined to revert all the split changes, in order to start 'fresh' and come up with the actual guideline for these cases and then make the change. |
|
I support reverting #2675 |
…ry#2617)" Contributes to open-telemetry#2726 This reverts open-telemetry#2617 We are reverting open-telemetry#2617 until we are certain how to resolve issue open-telemetry#2726 Also reverts the corresponding schema file changes done in open-telemetry#2688
tigrannajaryan
force-pushed
the
feature/tigran/revert-2617
branch
from
b2e4e3a to
e4d449a
Compare
|
This PR now includes reverting of #2675 |
|
@open-telemetry/specs-approvers I tried to revert carefully, but tables in markdown are tricky. Please review carefully to make sure I did not make mistakes. |
tigrannajaryan
changed the title
direction (#2617)"direction (#2617 #2675 #2688)"
tigrannajaryan
changed the title
direction (#2617 #2675 #2688)"direction" (#2617 #2675 #2688)
tigrannajaryan
changed the title
direction" (#2617 #2675 #2688)direction"
|
@tigrannajaryan I think we are good to go (enough reviews, enough time for people to disagree, etc). Good to merge? |
… "add metrics to replace metrics with `direction`" (open-telemetry#2748) Please review this carefully. It is not an automatic reverting, I had to fix merge conflicts manually and may have made mistakes, so a thorough review is needed. Changes: - This reverts open-telemetry#2617. We are reverting it until we are certain how to resolve issue open-telemetry#2726 - Also reverts the corresponding schema file changes done in open-telemetry#2688 - Also reverts open-telemetry#2675 ~Note that this does not revert open-telemetry#2675 which I believe to still be valid. If you think otherwise please speak.~ [UPDATE: discussed in Spec SIG and decided to revert 2675 too]. Contributes to open-telemetry#2726
… "add metrics to replace metrics with `direction`" (open-telemetry#2748) Please review this carefully. It is not an automatic reverting, I had to fix merge conflicts manually and may have made mistakes, so a thorough review is needed. Changes: - This reverts open-telemetry#2617. We are reverting it until we are certain how to resolve issue open-telemetry#2726 - Also reverts the corresponding schema file changes done in open-telemetry#2688 - Also reverts open-telemetry#2675 ~Note that this does not revert open-telemetry#2675 which I believe to still be valid. If you think otherwise please speak.~ [UPDATE: discussed in Spec SIG and decided to revert 2675 too]. Contributes to open-telemetry#2726
Please review this carefully. It is not an automatic reverting, I had to fix merge conflicts manually and may have made mistakes, so a thorough review is needed.
Changes:
direction#2617. We are reverting it until we are certain how to resolve issue Mistake while applying the logic in #2617 from #2589: process.network.io and system.network.* should not have been split #2726Note that this does not revert #2675 which I believe to still be valid. If you think otherwise please speak.[UPDATE: discussed in Spec SIG and decided to revert 2675 too].Contributes to #2726