Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thread semantic attributes for logs #2389

Closed
wants to merge 1 commit into from

Conversation

trask
Copy link
Member

@trask trask commented Mar 1, 2022

Changes

Adds thread semantic attributes for logs, copied from the thread semantic attributes for spans.

@trask trask force-pushed the thread-attributes-for-logs branch from 4b4db1a to 63222e7 Compare March 1, 2022 01:03
@trask trask marked this pull request as ready for review March 1, 2022 01:05
@trask trask requested review from a team March 1, 2022 01:05
@trask
Copy link
Member Author

trask commented Mar 1, 2022

/easycla

@arminru arminru added area:semantic-conventions Related to semantic conventions spec:logs Related to the specification/logs directory labels Mar 1, 2022
@tigrannajaryan
Copy link
Member

Adds thread semantic attributes for logs, copied from the thread semantic attributes for spans.

I don't think copying is the right approach. This creates unnecessary maintenance burden. A significant potion of attributes that can be recorded on spans can also be recorded on logs. Copying is not going to work.

We discussed this in the past and the thinking is that we need to move semantic convention to a common directory. @tedsuo had a PR which did not move forward: https://github.com/open-telemetry/opentelemetry-specification/pull/1977/files

Perhaps it is time to revive it.

Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we not use the tool to generate these attributes from yaml?

@tigrannajaryan
Copy link
Member

Why do we not use the tool to generate these attributes from yaml?

This too. We need to extend the generation to logs (but more importantly, in this particular case this should be one semantic convention shared with traces).

@trask
Copy link
Member Author

trask commented Mar 2, 2022

Closing for now as there's a lot of prerequisite tooling work and spec restructuring before this PR can move forward.

@trask trask closed this Mar 2, 2022
@trask trask deleted the thread-attributes-for-logs branch March 2, 2022 03:21
@bogdandrutu
Copy link
Member

@tigrannajaryan @trask would be good to at least start a tracking issue for this.

@tigrannajaryan
Copy link
Member

@tigrannajaryan @trask would be good to at least start a tracking issue for this.

Here is a tracking issue: #2397

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions spec:logs Related to the specification/logs directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants