-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add thread semantic attributes for logs #2389
Conversation
4b4db1a
to
63222e7
Compare
/easycla |
I don't think copying is the right approach. This creates unnecessary maintenance burden. A significant potion of attributes that can be recorded on spans can also be recorded on logs. Copying is not going to work. We discussed this in the past and the thinking is that we need to move semantic convention to a common directory. @tedsuo had a PR which did not move forward: https://github.com/open-telemetry/opentelemetry-specification/pull/1977/files Perhaps it is time to revive it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we not use the tool to generate these attributes from yaml?
This too. We need to extend the generation to logs (but more importantly, in this particular case this should be one semantic convention shared with traces). |
Closing for now as there's a lot of prerequisite tooling work and spec restructuring before this PR can move forward. |
@tigrannajaryan @trask would be good to at least start a tracking issue for this. |
Here is a tracking issue: #2397 |
Changes
Adds thread semantic attributes for logs, copied from the thread semantic attributes for spans.