-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify OTLP/HTTP port handling. #1985
Merged
tigrannajaryan
merged 7 commits into
open-telemetry:main
from
dynatrace-oss-contrib:otlp-http-port
Oct 12, 2021
Merged
Clarify OTLP/HTTP port handling. #1985
tigrannajaryan
merged 7 commits into
open-telemetry:main
from
dynatrace-oss-contrib:otlp-http-port
Oct 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oberon00
added
area:sdk
Related to the SDK
area:configuration
Related to configuring the SDK
labels
Oct 4, 2021
Oberon00
commented
Oct 4, 2021
anuraaga
approved these changes
Oct 4, 2021
iNikem
approved these changes
Oct 4, 2021
jsuereth
reviewed
Oct 4, 2021
tigrannajaryan
approved these changes
Oct 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
carlosalberto
approved these changes
Oct 5, 2021
arminru
approved these changes
Oct 7, 2021
reyang
approved these changes
Oct 12, 2021
jsuereth
approved these changes
Oct 12, 2021
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Clarifies that default ports for the URL schemes, not default OTLP/HTTP port should be used if no port is given in URL. See open-telemetry#1975 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies that default ports for the URL schemes, not default OTLP/HTTP port should be used if no port is given in URL.
See #1975 (comment)