Add OTLP protocol configuration options #1880
Conversation
|
cc @jsuereth (maybe I'm wrong but I think you were interested in this ;) ) |
There was a problem hiding this comment.
We need to confirm with maintainers that the meaning of these enums i the same across SDKs.
There was concern (previously), that "http/protobuf" and "http/json" are not specific enough in what they mean, and that existing "http/protobuf" or "http/json" exporters in SDKs are actually incompatible with each other.
Opening this as a blocking comments until we have verification from language SDK maintainers that they're comfortable with this as written given the previous attempt to specify this.
|
I've added new commits which revert my first attempt in favor of the approach discussed in the sig meeting of adding new exporter options for the different protocols instead of adding a new configuration option. |
|
Ping @jsuereth |
|
@jsuereth Ping ;) Is your original changes request still standing? Else, let's merge this one. |
There was a problem hiding this comment.
Think we've left this open with sufficient time for SDK concerns and raised it multiple SiGs. I left ONE comment in the maintainer channel for last-minute discussions.
I don't think this belongs in the specificatoin but taking note here:
Compliance to protocol should be evaluated via Otel Collector ingestion of telemetry.
|
@jack-berg Oops, looks like we don't have a CHANGELOG entry, please add one ;) |
|
All set @carlosalberto! |
Fixes #1879
Changes
Add
OTEL_EXPORTER_OTLP_PROTOCOL,OTEL_EXPORTER_OTLP_TRACES_PROTOCOL, andOTEL_EXPORTER_OTLP_METRICS_PROTOCOLenvironment variables for specifying the OTLP protocol.