Small clarification for default's service.name for exporters. #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkwatson
approved these changes
Jan 28, 2021
Oberon00
reviewed
Jan 28, 2021
Oberon00
approved these changes
Jan 28, 2021
arminru
approved these changes
Jan 28, 2021
yurishkuro
approved these changes
Jan 28, 2021
codeboten
approved these changes
Jan 28, 2021
Co-authored-by: Christian Neumüller <[email protected]>
Co-authored-by: Christian Neumüller <[email protected]>
cijothomas
reviewed
Jan 28, 2021
cijothomas
approved these changes
Jan 28, 2021
I'd add it, as this is easy to overlook by language SIGs. A changelog would make it more easy. |
iNikem
reviewed
Jan 29, 2021
Co-authored-by: Nikita Salnikov-Tarnovski <[email protected]>
carlosalberto
added a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1237
Fixes #1380
Small clarification on using the default
Resourceis noservice.namewas used.PS - Don't think we need a CHANGELOG entry for this, but happy to add one if needed.