Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose a definition of Collector to be included in the specification #4309

Closed
codeboten opened this issue Nov 25, 2024 · 4 comments
Closed
Assignees
Labels
spec:miscellaneous For issues that don't match any other spec label

Comments

@codeboten
Copy link
Contributor

What are you trying to achieve?

I'd like to include a definition of what a collector is in the specification. I think this will help set expectations for end users. I discussed this with various Collector contributors at Kubecon NA 2024 as well as other collaborators in the OTel community and everyone seemed to think it would be good to have this in the spec.

Additional context.

This is related to open-telemetry/opentelemetry-collector#8555

@codeboten codeboten added the spec:miscellaneous For issues that don't match any other spec label label Nov 25, 2024
@codeboten codeboten self-assigned this Nov 25, 2024
@tigrannajaryan
Copy link
Member

everyone seemed to think it would be good to have this in the spec.

@codeboten can you please expand a bit on this? I would like to understand what the goal is.

Do we see a particular confusion about what a Collector is and want to clarify it? Do we think there may be more than one "Collector" implementations that can match the spec if we define it?

what a collector is in the specification.

Anything prevents from defining this in the Collector repo itself by Collector maintainers? Does the location of the definition of "what a Collector is" matter? Do you want it to be in the specification repo because you are looking for TC/GC help?

@codeboten
Copy link
Contributor Author

@codeboten can you please expand a bit on this? I would like to understand what the goal is.

The purpose of defining what a Collector is in the specification is to document expectations and boundaries of collector, collector distro, collector components for both end users and vendors. Mostly I want to ensure that users aren't locked in to a thing that claims to be an opentelemetry collector because there isn't an existing definition of it.

As a user, i want to ensure that whatever thing i use will allow me to bring my own components from the OpenTelemetry ecosystem.

As a provider of a Collector (vendor, open source project, or other), having a definition will allow me to validate that whatever I'm offering to end users, matches their expectations by testing my thing against the specified behaviour.

Note that the goal here is not to disqualify existing collectors things in the wild today. Ideally this just means that anything calling itself a collector will be able to take the steps to be compatible with the specification we agree on.

@yurishkuro
Copy link
Member

Please close this issue and continue discussion on the original ticket in the Collector repo, until there is actually a decision.

@codeboten
Copy link
Contributor Author

I opened the issue here to bring this up to the attention of the specification SIG which was done today. During the call there was a consensus that having a definition in the specification was desirable. I can close this as completed.

codeboten added a commit to codeboten/opentelemetry-specification that referenced this issue Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:miscellaneous For issues that don't match any other spec label
Projects
None yet
Development

No branches or pull requests

3 participants