-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider removing include_trace_context from "Get a Logger" API #3394
Comments
I think we should remove it. If you look at the git history, the parameter was originally added as part of the event API in #2676. Note that we didn't have an explicit Later in #2941 we split out the events API from the logs API, but kept the Later in #2927 we added an explicit As mentioned here I don't see how |
include_trace_context parameter has been a source of confusion (see for example here).
I suggest to remove it for now. It is supposed to be an optional parameter, so it can be added later as an optional parameter after we understand its behavior and interaction with the rest of context functionality better. We have a precedent of adding optional parameters to Stable APIs in the past, so it is OK to do so after the Bridge API is declared Stable.
The text was updated successfully, but these errors were encountered: