Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move inmemory exporter for logs to diff namespace #2538

Merged

Conversation

cijothomas
Copy link
Member

opentelemetry_sdk::testing::logs::{InMemoryLogExporter, InMemoryLogExporterBuilder};
to
opentelemetry_sdk::logs::{InMemoryLogExporter, InMemoryLogExporterBuilder};

This is already under a feature-flag "testing", so this avoids the unnecessary "testing" module name.

@cijothomas cijothomas requested a review from a team as a code owner January 23, 2025 02:04
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.8%. Comparing base (5935cca) to head (415bb38).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2538   +/-   ##
=====================================
  Coverage   77.8%   77.8%           
=====================================
  Files        123     123           
  Lines      23047   23047           
=====================================
  Hits       17931   17931           
  Misses      5116    5116           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we need similar for other in-memory exporter too.

@cijothomas cijothomas merged commit fdf4a63 into open-telemetry:main Jan 23, 2025
21 checks passed
@cijothomas cijothomas deleted the cijothomas/inmemory-rename-logs branch January 23, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants