Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use last value aggregator for value observers #241

Merged
merged 1 commit into from
Oct 3, 2020

Conversation

jtescher
Copy link
Member

@jtescher jtescher commented Oct 3, 2020

@jtescher jtescher requested a review from a team October 3, 2020 20:05
@jtescher
Copy link
Member Author

jtescher commented Oct 3, 2020

@TommyCpp hope this DDSkechConfig makes sense for use by selectors, basically the selector will need to have a collection of these values to use for each aggregator so it seemed clearer to have this be its own struct.

Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtescher Yeah it looks like a nice fix, Thanks!

@jtescher jtescher merged commit 863202c into master Oct 3, 2020
@jtescher jtescher deleted the last-value-selector branch October 3, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants