Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace once_cell::Lazy with std::sync::OnceLock for global Initialization in otel-sdk crate #2342

Merged
merged 10 commits into from
Nov 27, 2024

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Nov 26, 2024

Changes

changes similar to #2326 for otel-sdk.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team as a code owner November 26, 2024 00:04
@lalitb
Copy link
Member Author

lalitb commented Nov 26, 2024

The CI build is failing unrelated to this PR:

  Compiling sysinfo v0.30.13
error[E0599]: no method named `len` found for type `i8` in the current scope
   --> /Users/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/sysinfo-0.30.13/src/unix/apple/macos/process.rs:436:53
    |
436 |         Some(node.vip_path.len() * node.vip_path[0].len()),
    |                                                     ^^^
    |
help: there is a method `le` with a similar name, but with different arguments
   --> /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/core/src/cmp.rs:1196:5

For more information about this error, try `rustc --explain E0599`.
error: could not compile `sysinfo` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

Have raised a bug for sysinfo for now - GuillaumeGomez/sysinfo#1392

Copy link
Contributor

@hdost hdost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One less dependency 🤘

@cijothomas cijothomas added this to the 0.27.1 milestone Nov 26, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 74.66667% with 19 lines in your changes missing coverage. Please review.

Project coverage is 79.5%. Comparing base (8e6b479) to head (eee4985).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-sdk/src/logs/log_emitter.rs 0.0% 10 Missing ⚠️
opentelemetry-sdk/src/propagation/trace_context.rs 0.0% 5 Missing ⚠️
opentelemetry-sdk/src/propagation/baggage.rs 0.0% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2342     +/-   ##
=======================================
- Coverage   79.5%   79.5%   -0.1%     
=======================================
  Files        123     123             
  Lines      21381   21395     +14     
=======================================
+ Hits       17003   17012      +9     
- Misses      4378    4383      +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lalitb lalitb merged commit fa6e6cd into open-telemetry:main Nov 27, 2024
21 of 23 checks passed
@hdost hdost added semver-check For PRs that need to run semver compliance checks and removed semver-check For PRs that need to run semver compliance checks labels Dec 3, 2024
pitoniak32 pushed a commit to pitoniak32/opentelemetry-rust that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants