Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Wrong StatusCode ordinal in stdout exporter #1453

Closed
j-white opened this issue Dec 24, 2023 · 0 comments · Fixed by #1454
Closed

[Bug]: Wrong StatusCode ordinal in stdout exporter #1453

j-white opened this issue Dec 24, 2023 · 0 comments · Fixed by #1454
Labels
bug Something isn't working triage:todo Needs to be traiged.

Comments

@j-white
Copy link
Contributor

j-white commented Dec 24, 2023

What happened?

An Error is recorded as status=1, and Ok as status=2.:
https://github.com/open-telemetry/opentelemetry-rust/blob/v0.21.1/opentelemetry-stdout/src/trace/transform.rs#L214

These should be flipped to match the standard:
https://github.com/open-telemetry/opentelemetry-proto/blob/v1.0.0/opentelemetry/proto/trace/v1/trace.proto#L269

API Version

1.0

SDK Version

0.21.1

What Exporters are you seeing the problem on?

N/A

Relevant log output

No response
@j-white j-white added bug Something isn't working triage:todo Needs to be traiged. labels Dec 24, 2023
j-white added a commit to j-white/opentelemetry-rust that referenced this issue Dec 24, 2023
@j-white
Fix StatusCode in stdout exporter (open-telemetry#1453)
2ee6b6a
@j-white j-white mentioned this issue Dec 24, 2023
Merged
4 tasks
j-white added a commit to j-white/opentelemetry-rust that referenced this issue Dec 24, 2023
@j-white
Fix StatusCode in stdout exporter (open-telemetry#1453)
c5e0b2b
j-white added a commit to j-white/opentelemetry-rust that referenced this issue Dec 24, 2023
@j-white
Fix StatusCode in stdout exporter (open-telemetry#1453)
80a190f
jtescher pushed a commit that referenced this issue Jan 4, 2024
@j-white @lalitb
Fix StatusCode in stdout exporter (#1453) (#1454)
4c5c101 
Fixes #1453

## Changes

Swap the ordinals to match the spec.

Co-authored-by: Lalit Kumar Bhasin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working triage:todo Needs to be traiged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix StatusCode in stdout exporter (#1453) j-white/opentelemetry-rust
1 participant
@j-white