Fix Sinatra example in docker-compose.yml #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the Sinatra example so that it runs out of the box like the standard `ex-http` example when called with `docker-compose run ex-adapter-sinatra`.
highb
requested review from
bai,
dazuma,
elskwid,
fbogsany,
luvtechno and
mwear
as code owners
mwear
approved these changes
May 13, 2020
|
I'm running it by my boss/legal now. :)
…On Tue, May 12, 2020, 6:14 PM Matthew Wear ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM. Would you mind signing the CLA
<https://identity.linuxfoundation.org/projects/cncf>?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#260 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFZQKEJHW44JJO2Z2ONLZDRRHX7JANCNFSM4M7IMVBA>
.
|
fbogsany
approved these changes
May 13, 2020
|
I've opened a support ticket to get this sorted. |
|
@fbogsany Looks like the CLA bot is happy now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the Sinatra example so that it runs out of the box
like the standard
ex-httpexample when called withdocker-compose run ex-adapter-sinatra.