ext/mysql: Add instrumentor interface #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement to helper methods to allow users to enable / disable instrumentation in a single connection object.
…__.py Co-authored-by: Diego Hurtado <[email protected]>
…__.py Co-authored-by: Diego Hurtado <[email protected]>
Implement MySQLInstrumentor to (un)instrument the library, also implement (un)instrument_connection to work at the connection level.
mauriciovasquezbernal
added
ext
instrumentation
mauriciovasquezbernal
changed the title
codeboten
approved these changes
May 8, 2020
ext/opentelemetry-ext-mysql/src/opentelemetry/ext/mysql/__init__.py
Outdated
Show resolved
Hide resolved
ext/opentelemetry-ext-mysql/src/opentelemetry/ext/mysql/__init__.py
Outdated
Show resolved
Hide resolved
lzchen
approved these changes
May 8, 2020
…__.py Co-authored-by: alrex <[email protected]>
…__.py Co-authored-by: alrex <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MySQLInstrumentor to (un)instrument the library, also implement (un)instrument_connection to work at the connection level.
Depends on #624.