OTLP exporter: encode instrumentation scope schema url and attributes to otlp proto #4359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…messages. update tests to cover the schema_url and attributes.
|
Ready for review. Thanks in advance for the feedback! |
xrmx
reviewed
Dec 23, 2024
Co-authored-by: Riccardo Magliocchetti <[email protected]>
|
@dbarker fyi no need to update this at every commit, we usually merge main before merging or during reviews 😅 |
haha.. thanks for the heads up and review. Just making sure it is up to date and conflict free.. :) |
|
@xrmx Any chance you can review this week? I'd like to get this in for the next release if possible. Happy to address any issues you see. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4358
This PR updates the OTLP encoding methods to encode the Instrumentation Scope schema url and attributes to the proto messages for logs, metrics and traces.
Without this change the schema url and attributes set on the GetMeter, GetTracer, and GetLogger methods from providers are not exported in OTLP protobuf messages.
Unit tests have been updated to check these fields are populated with the fix.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
This PR adds new cases to the logs, metrics, and trace encoding tests in
opentelemetry-exporter-otlp-proto-commonto cover the instrumentation scope schema url and attributes.Does This PR Require a Contrib Repo Change?
Checklist: