Incorporate resource detectors to auto instrumentation #3181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanketmehta28
suggested changes
Feb 16, 2023
opentelemetry-sdk/src/opentelemetry/sdk/environment_variables.py
Outdated
Show resolved
Hide resolved
ocelotl
added
the
Approve Public API check
sanketmehta28
approved these changes
Mar 2, 2023
ocelotl
force-pushed
the
issue_3172
branch
2 times, most recently
from
be89882 to
9474dc6
Compare
srikanthccv
reviewed
Mar 22, 2023
opentelemetry-sdk/src/opentelemetry/sdk/environment_variables.py
Outdated
Show resolved
Hide resolved
ocelotl
force-pushed
the
issue_3172
branch
3 times, most recently
from
1098c9a to
955cce1
Compare
srikanthccv
reviewed
Mar 29, 2023
opentelemetry-sdk/src/opentelemetry/sdk/environment_variables.py
Outdated
Show resolved
Hide resolved
This is an experimental feature. Fixes open-telemetry#3172
srikanthccv
reviewed
Mar 30, 2023
opentelemetry-sdk/src/opentelemetry/sdk/environment_variables.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Srikanth Chekuri <[email protected]>
srikanthccv
approved these changes
Mar 31, 2023
|
Does this work with the ECS resource detector in |
xrmx
added a commit
to xrmx/opentelemetry-python
that referenced
this pull request
Dec 23, 2024
After open-telemetry#3181 ResourceDetector instances cannot call Resource.create otherwise when using auto-instrumentation you'll go into an infinite loop trying to load resource detectors.
11 tasks
aabmass
added a commit
that referenced
this pull request
Dec 23, 2024
* opentelemetry-sdk: clarify Resource.create usage After #3181 ResourceDetector instances cannot call Resource.create otherwise when using auto-instrumentation you'll go into an infinite loop trying to load resource detectors. * Update opentelemetry-sdk/src/opentelemetry/sdk/resources/__init__.py Co-authored-by: Aaron Abbott <[email protected]> * Update opentelemetry-sdk/src/opentelemetry/sdk/resources/__init__.py Co-authored-by: Aaron Abbott <[email protected]> * More precise instructions --------- Co-authored-by: Aaron Abbott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experimental feature.
Fixes #3096
This feature adds a new environment variable
OTEL_EXPERIMENTAL_RESOURCE_DETECTORSwhich while it does not exist yet in the spec, it is added here to show how this feature can work.This PR is based on #3168.