Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LogEmitterProvider.force_flush hanging randomly #2714

Merged
merged 2 commits into from
May 25, 2022
Merged

Fix LogEmitterProvider.force_flush hanging randomly #2714

merged 2 commits into from
May 25, 2022

Conversation

overmeulen
Copy link
Contributor

@overmeulen overmeulen commented May 24, 2022 •
edited
Loading

Description

Fixes #2713

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • We have a 10 minutes NFR test on our side that was almost consistently failing. All runs are now green with this fix

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@overmeulen overmeulen requested a review from a team May 24, 2022 13:17
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 24, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: overmeulen / name: Olivier VERMEULEN (0f06493)
  • ✅ login: srikanthccv / name: Srikanth Chekuri (f421e4d)

@jarias-lfx
Copy link

/easycla

@overmeulen overmeulen force-pushed the bugfix/logs/force-flush branch from f421e4d to de6da57 Compare May 25, 2022 07:06
@ocelotl ocelotl merged commit 8200f45 into open-telemetry:main May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv approved these changes

@ocelotl ocelotl ocelotl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LogEmitterProvider.force_flush hangs and ultimately timeouts randomly
4 participants
@overmeulen @jarias-lfx @ocelotl @srikanthccv