Request/response hooks for Falcon #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
requested review from
a team,
codeboten and
aabmass
and removed request for
a team
owais
force-pushed
the
falcon-request-hooks
branch
8 times, most recently
from
882c13f to
35232e0
Compare
owais
commented
Apr 6, 2021
owais
force-pushed
the
falcon-request-hooks
branch
from
35232e0 to
83dd3f7
Compare
aabmass
approved these changes
Apr 8, 2021
...on/opentelemetry-instrumentation-falcon/src/opentelemetry/instrumentation/falcon/__init__.py
Outdated
Show resolved
Hide resolved
lzchen
reviewed
Apr 9, 2021
| @@ -83,21 +130,25 @@ class FalconInstrumentor(BaseInstrumentor): | |||
|
|
|||
| def _instrument(self, **kwargs): | |||
| self._original_falcon_api = falcon.API | |||
| falcon.API = _InstrumentedFalconAPI | |||
| falcon.API = partial(_InstrumentedFalconAPI, **kwargs) | |||
There was a problem hiding this comment.
Should we have explicit kwargs names like the other instrumentations?
There was a problem hiding this comment.
Do you mean something like:
falcon.API = partial(
_InstrumentedFalconAPI,
traced_request_attributes=kwargs.pop("traced_request_attributes", None),
request_hook=kwargs.pop("request_hook", None),
response_hook=kwargs.pop("response_hook", None),
)?
We could but we have to do the same thing again below so don't see a lot of value in it. Still open to adding it.
lzchen
reviewed
Apr 9, 2021
| @@ -178,6 +240,9 @@ def process_response( | |||
| self, req, resp, resource, req_succeeded=None | |||
| ): # pylint:disable=R0201 | |||
| span = req.env.get(_ENVIRON_SPAN_KEY) | |||
| if span and self._response_hook: | |||
There was a problem hiding this comment.
Should this be called right before the span ends?
owais
force-pushed
the
falcon-request-hooks
branch
from
20eb5f3 to
4014879
Compare
owais
force-pushed
the
falcon-request-hooks
branch
from
4014879 to
dc8eac3
Compare
lzchen
approved these changes
Apr 13, 2021
codeboten
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for request and response hooks to Falcon instrumentation.
Fixes #137
Fixes #362
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.