-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unit in system metrics #2922
Conversation
It can't hurt I guess, but aren't the names of the metrics out of spec? |
There is at least another "bytes" usage, please update that too |
Fixed it. Thank you! |
They aren't. But I guess this is the legacy we will need to carry until we find a deprecation path. For metric units fixes, I believe it is a reasonable change because the OTEL dependency services won't expect the units as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM since we are not changing metric names, but worried about this comment in semconv:
>SHOULD NOT adopt any breaking changes from document until the system semantic conventions are marked stable. Conventions include, but are not limited to, attributes, metric names, and unit of measure.
We are including unit of measure changes
Description
Convert system metric to use UCUM to follow OpenTelemetry semantic conventions
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.