Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure async generators are awaited #2792

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Conversation

rrjjvv
Copy link
Contributor

@rrjjvv rrjjvv commented Aug 9, 2024

Description

This change simply awaits coroutines that are not being processed; it basically corrects #2541. There is no new functionality and no new dependencies.

Fixes #2791

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

Copy link

linux-foundation-easycla bot commented Aug 9, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@rrjjvv rrjjvv requested a review from a team August 9, 2024 17:44
@rrjjvv
Copy link
Contributor Author

rrjjvv commented Aug 9, 2024

Technically I didn't add tests; since the existing test was arguably incomplete, I thought it would be better and clearer to just fix the existing test. I'd be happy to revert it and create a dedicated test if that's preferred.

@lzchen lzchen merged commit 6981035 into open-telemetry:main Aug 12, 2024
521 checks passed
@rrjjvv rrjjvv deleted the asyncio-gen-fix branch August 19, 2024 19:41
xrmx pushed a commit to xrmx/opentelemetry-python-contrib that referenced this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

asyncio instrumentation does not await generator coroutines
2 participants