Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit and test opentelemetry-instrumentation-dbapi NoOpTracerProvider #1607

Merged
merged 5 commits into from
Feb 13, 2023
Merged

Audit and test opentelemetry-instrumentation-dbapi NoOpTracerProvider #1607

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
71ac057
Audit and test opentelemetry-instrumentation-dbapi NoOpTracerProvider
Akochavi Jan 29, 2023
9d854ea
wip
Akochavi Feb 5, 2023
2e9d4ea
Merge branch 'main' into audit-and-test-opentelemetry-instrumentation…
shalevr Feb 5, 2023
896a4a7
Merge branch 'main' into audit-and-test-opentelemetry-instrumentation…
srikanthccv Feb 11, 2023
66418c7
Merge branch 'main' into audit-and-test-opentelemetry-instrumentation…
shalevr Feb 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions instrumentation/opentelemetry-instrumentation-dbapi/tests/test_dbapi_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,20 @@ def test_custom_tracer_provider_dbapi(self):
self.assertEqual(span.resource.attributes["db-resource-key"], "value")
self.assertIs(span.status.status_code, trace_api.StatusCode.ERROR)

def test_no_op_tracer_provider(self):
db_integration = dbapi.DatabaseApiIntegration(
self.tracer, "testcomponent",
tracer_provider=trace_api.NoOpTracerProvider()
)

mock_connection = db_integration.wrapped_connection(
mock_connect, {}, {}
)
cursor = mock_connection.cursor()
cursor.executemany("Test query")
spans_list = self.memory_exporter.get_finished_spans()
self.assertEqual(len(spans_list), 0)

def test_executemany(self):
db_integration = dbapi.DatabaseApiIntegration(
"testname", "testcomponent"
Expand Down