Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASGI support for django instrumentation #334

Closed
srikanthccv opened this issue Feb 13, 2021 · 0 comments · Fixed by #391
Closed

ASGI support for django instrumentation #334

srikanthccv opened this issue Feb 13, 2021 · 0 comments · Fixed by #391
Labels
feature-request help wanted Extra attention is needed

Comments

@srikanthccv
Copy link
Member

Things should be done for adding support for ASGI

  1. Collect the request attributes from scope
  2. HTTP headers are list of key, value pairs in byte format, so needs to make necessary changes for context propagation
@srikanthccv srikanthccv mentioned this issue Feb 13, 2021
Closed
@adamantike adamantike mentioned this issue Mar 25, 2021
Closed
adamantike added a commit to adamantike/opentelemetry-python-contrib that referenced this issue Mar 31, 2021
@adamantike
WIP: Add Django ASGI support
6d68ceb 
Still a WIP, this diff adds `asgi` as an extra, and uses its methods if
the current request is an `ASGIRequest`.

I still need to dig deeper in the current test suite, to find a way to
duplicate the tests in
`instrumentation/opentelemetry-instrumentation-django/tests/test_middleware.py`,
but using an
[`AsyncClient`](https://docs.djangoproject.com/en/3.1/topics/testing/tools/#testing-asynchronous-code).

Fixes open-telemetry#165, open-telemetry#185, open-telemetry#280, open-telemetry#334.
@adamantike adamantike mentioned this issue Mar 31, 2021
Merged
7 tasks
adamantike added a commit to adamantike/opentelemetry-python-contrib that referenced this issue Mar 31, 2021
@adamantike
WIP: Add Django ASGI support
57c7dd5 
Still a WIP, this diff adds `asgi` as an extra, and uses its methods if
the current request is an `ASGIRequest`.

I still need to dig deeper in the current test suite, to find a way to
duplicate the tests in
`instrumentation/opentelemetry-instrumentation-django/tests/test_middleware.py`,
but using an
[`AsyncClient`](https://docs.djangoproject.com/en/3.1/topics/testing/tools/#testing-asynchronous-code).

Fixes open-telemetry#165, open-telemetry#185, open-telemetry#280, open-telemetry#334.
@owais owais added feature-request help wanted Extra attention is needed labels Apr 6, 2021
adamantike added a commit to adamantike/opentelemetry-python-contrib that referenced this issue Apr 6, 2021
@adamantike
WIP: Add Django ASGI support
5774201 
Still a WIP, this diff adds `asgi` as an extra, and uses its methods if
the current request is an `ASGIRequest`.

I still need to dig deeper in the current test suite, to find a way to
duplicate the tests in
`instrumentation/opentelemetry-instrumentation-django/tests/test_middleware.py`,
but using an
[`AsyncClient`](https://docs.djangoproject.com/en/3.1/topics/testing/tools/#testing-asynchronous-code).

Fixes open-telemetry#165, open-telemetry#185, open-telemetry#280, open-telemetry#334.
adamantike added a commit to adamantike/opentelemetry-python-contrib that referenced this issue May 30, 2021
@adamantike
WIP: Add Django ASGI support
2fb9168 
Still a WIP, this diff adds `asgi` as an extra, and uses its methods if
the current request is an `ASGIRequest`.

I still need to dig deeper in the current test suite, to find a way to
duplicate the tests in
`instrumentation/opentelemetry-instrumentation-django/tests/test_middleware.py`,
but using an
[`AsyncClient`](https://docs.djangoproject.com/en/3.1/topics/testing/tools/#testing-asynchronous-code).

Fixes open-telemetry#165, open-telemetry#185, open-telemetry#280, open-telemetry#334.
adamantike added a commit to adamantike/opentelemetry-python-contrib that referenced this issue Jun 3, 2021
@adamantike
Add Django ASGI support
864320a 
This diff adds `asgi` as an extra, and uses its methods if the current
request is an `ASGIRequest`.

I still need to dig deeper in the current test suite, to find a way to
duplicate the tests in
`instrumentation/opentelemetry-instrumentation-django/tests/test_middleware.py`,
but using an
[`AsyncClient`](https://docs.djangoproject.com/en/3.1/topics/testing/tools/#testing-asynchronous-code).

Fixes open-telemetry#165, open-telemetry#185, open-telemetry#280, open-telemetry#334.
adamantike added a commit to adamantike/opentelemetry-python-contrib that referenced this issue Jul 6, 2021
@adamantike
Add Django ASGI support
00eac94 
This diff adds `asgi` as an extra, and uses its methods if the current
request is an `ASGIRequest`.

I still need to dig deeper in the current test suite, to find a way to
duplicate the tests in
`instrumentation/opentelemetry-instrumentation-django/tests/test_middleware.py`,
but using an
[`AsyncClient`](https://docs.djangoproject.com/en/3.1/topics/testing/tools/#testing-asynchronous-code).

Fixes open-telemetry#165, open-telemetry#185, open-telemetry#280, open-telemetry#334.
adamantike added a commit to adamantike/opentelemetry-python-contrib that referenced this issue Sep 21, 2021
@adamantike
Add Django ASGI support
0456740 
This diff adds `asgi` as an extra, and uses its methods if the current
request is an `ASGIRequest`.

I still need to dig deeper in the current test suite, to find a way to
duplicate the tests in
`instrumentation/opentelemetry-instrumentation-django/tests/test_middleware.py`,
but using an
[`AsyncClient`](https://docs.djangoproject.com/en/3.1/topics/testing/tools/#testing-asynchronous-code).

Fixes open-telemetry#165, open-telemetry#185, open-telemetry#280, open-telemetry#334.
adamantike added a commit to adamantike/opentelemetry-python-contrib that referenced this issue Sep 28, 2021
@adamantike
Add Django ASGI support
c12a600 
This diff adds `asgi` as an extra, and uses its methods if the current
request is an `ASGIRequest`.

I still need to dig deeper in the current test suite, to find a way to
duplicate the tests in
`instrumentation/opentelemetry-instrumentation-django/tests/test_middleware.py`,
but using an
[`AsyncClient`](https://docs.djangoproject.com/en/3.1/topics/testing/tools/#testing-asynchronous-code).

Fixes open-telemetry#165, open-telemetry#185, open-telemetry#280, open-telemetry#334.
adamantike added a commit to adamantike/opentelemetry-python-contrib that referenced this issue Oct 11, 2021
@adamantike
Add Django ASGI support
d328484 
This diff adds `asgi` as an extra, and uses its methods if the current
request is an `ASGIRequest`.

I still need to dig deeper in the current test suite, to find a way to
duplicate the tests in
`instrumentation/opentelemetry-instrumentation-django/tests/test_middleware.py`,
but using an
[`AsyncClient`](https://docs.djangoproject.com/en/3.1/topics/testing/tools/#testing-asynchronous-code).

Fixes open-telemetry#165, open-telemetry#185, open-telemetry#280, open-telemetry#334.
@slamer59 slamer59 mentioned this issue Jul 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Django ASGI support adamantike/opentelemetry-python-contrib
2 participants
@owais @srikanthccv