Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the 'optional' label in metrics.proto, because it will cause compilation errors when the protobuf version is less than 3.15.0 #452

Closed
wants to merge 2 commits into from
Closed

Remove the 'optional' label in metrics.proto, because it will cause compilation errors when the protobuf version is less than 3.15.0 #452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
752f0ff
Remove the 'optional' label in metrics.proto, because it will cause c…
ninghejun Mar 3, 2023
326b3f0
remove optional for proto 3
ninghejun Mar 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ Full list of differences found in [this compare](https://github.com/open-telemet

### Changed

* Remove if no changes for this section before release.
* Remove the 'optional' label in metrics.proto.
([#452](https://github.com/open-telemetry/opentelemetry-proto/pull/452))

### Added

Expand Down
14 changes: 7 additions & 7 deletions opentelemetry/proto/metrics/v1/metrics.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ message HistogramDataPoint {
// Negative events *can* be recorded, but sum should not be filled out when
// doing so. This is specifically to enforce compatibility w/ OpenMetrics,
// see: https://github.com/OpenObservability/OpenMetrics/blob/main/specification/OpenMetrics.md#histogram
optional double sum = 5;
double sum = 5;

// bucket_counts is an optional field contains the count values of histogram
// for each bucket.
Expand Down Expand Up @@ -449,10 +449,10 @@ message HistogramDataPoint {
uint32 flags = 10;

// min is the minimum value over (start_time, end_time].
optional double min = 11;
double min = 11;

// max is the maximum value over (start_time, end_time].
optional double max = 12;
double max = 12;
}

// ExponentialHistogramDataPoint is a single data point in a timeseries that describes the
Expand Down Expand Up @@ -493,7 +493,7 @@ message ExponentialHistogramDataPoint {
// Negative events *can* be recorded, but sum should not be filled out when
// doing so. This is specifically to enforce compatibility w/ OpenMetrics,
// see: https://github.com/OpenObservability/OpenMetrics/blob/main/specification/OpenMetrics.md#histogram
optional double sum = 5;
double sum = 5;

// scale describes the resolution of the histogram. Boundaries are
// located at powers of the base, where:
Expand Down Expand Up @@ -557,18 +557,18 @@ message ExponentialHistogramDataPoint {
repeated Exemplar exemplars = 11;

// min is the minimum value over (start_time, end_time].
optional double min = 12;
double min = 12;

// max is the maximum value over (start_time, end_time].
optional double max = 13;
double max = 13;

// ZeroThreshold may be optionally set to convey the width of the zero
// region. Where the zero region is defined as the closed interval
// [-ZeroThreshold, ZeroThreshold].
// When ZeroThreshold is unset or 0, zero count bucket stores
// values that cannot be expressed using the standard exponential formula as
// well as values that have been rounded to zero.
optional double zero_threshold = 14;
double zero_threshold = 14;
}

// SummaryDataPoint is a single data point in a timeseries that describes the
Expand Down