Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding InstrumentationLibrary to SDK #228

Closed
riticksingh opened this issue Dec 2, 2020 · 7 comments · Fixed by #392
Closed

Adding InstrumentationLibrary to SDK #228

riticksingh opened this issue Dec 2, 2020 · 7 comments · Fixed by #392
Labels
bite sized This is a small chunk of work (good for new or time limited contributors!) enhancement New feature or request good first issue Good for newcomers help wanted This issue is looking for someone to work on it

Comments

@riticksingh
Copy link
Contributor

Adding instrumentation feature to opentelemetry-php to sdk mentioned here: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/sdk.md#additional-span-interfaces

While working for OTLP/GRPC , it requires Instrumentation library in sdk for dealing with proto files

Something like this : opentelemetry-go reference

@bobstrecansky bobstrecansky added bite sized This is a small chunk of work (good for new or time limited contributors!) enhancement New feature or request good first issue Good for newcomers help wanted This issue is looking for someone to work on it labels Dec 2, 2020
@bobstrecansky
Copy link
Collaborator

@riticksingh - are you still planning on working on this?

@riticksingh
Copy link
Contributor Author

I am not getting the exact definition for Instrumentation from specification repo

@bobstrecansky
Copy link
Collaborator

Have you asked in the specification gitter channel for more specifics?

@riticksingh
Copy link
Contributor Author

Yup I asked the in channel of specification but doesn't got any reply

@lalex
Copy link
Contributor

lalex commented Jan 4, 2021

@riticksingh InstrumentationLibrary was added in #101 and then was replaced by ResourceInfo in #133, but the spec has been updated after (open-telemetry/opentelemetry-specification#616).

@riticksingh
Copy link
Contributor Author

Ok I will go through this

@bobstrecansky
Copy link
Collaborator

@riticksingh - what's the status of this?

lalex pushed a commit to lalex/opentelemetry-php that referenced this issue Aug 5, 2021
Reintroduce InstrumentationLibrary
dada4ce 
Fixes open-telemetry#228
lalex added a commit to lalex/opentelemetry-php that referenced this issue Aug 5, 2021
@lalex
Reintroduce InstrumentationLibrary
c7e5dea 
Fixes open-telemetry#228
@lalex lalex mentioned this issue Aug 5, 2021
Merged
bobstrecansky pushed a commit that referenced this issue Aug 6, 2021
@lalex
Reintroduce InstrumentationLibrary (#392)
44b09b3 
* Reintroduce InstrumentationLibrary

Fixes #228

* fix line-numbers in GetStackTrace tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bite sized This is a small chunk of work (good for new or time limited contributors!) enhancement New feature or request good first issue Good for newcomers help wanted This issue is looking for someone to work on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reintroduce InstrumentationLibrary lalex/opentelemetry-php
3 participants
@lalex @bobstrecansky @riticksingh