Support DotNet auto-instrumentation #976
Conversation
…or into support-dotnet-autoinstrumentation
…or into support-dotnet-autoinstrumentation
…or into support-dotnet-autoinstrumentation
…or into support-dotnet-autoinstrumentation
avadhut123pisal
changed the title
|
e2e test case is failing for newly added dot-net auto-instrumentation with the error in pulling the docker image |
Please open a separate PR just to build and publish the image |
I have opened a separate PR to build and publish the image #989 |
…tor into support-dotnet-autoinstrumentation
…_DOTNET_AUTO_TRACES_ENABLED_INSTRUMENTATIONS
|
what is the binary file |
| argument: "0.25" | ||
| dotnet: | ||
| env: | ||
| - name: OTEL_DOTNET_AUTO_TRACES_ENABLED_INSTRUMENTATIONS |
There was a problem hiding this comment.
is this required? What happens if the variable is empty?
There was a problem hiding this comment.
The PR #932 Enable all trace instrumentations by default (simplified) for enabling the all trace instrumentation by default was merged few days back. It is not available as a part of opentelemetry-dotnet-instrumentation v0.2.0-beta.1.
So, OTEL_DOTNET_AUTO_TRACES_ENABLED_INSTRUMENTATIONS is required to be specified for the release opentelemetry-dotnet-instrumentation v0.2.0-beta.1.
If it is empty, then applications runs but trace instrumentation does not work.
There was a problem hiding this comment.
Will this change in the future? If no the operator should set this variable on the behalf of the user.
There was a problem hiding this comment.
Previously, this env variable's name was OTEL_DOTNET_TRACER_INSTRUMENTATIONS . In v0.2.0-beta.1, it is renamed to OTEL_DOTNET_AUTO_TRACES_ENABLED_INSTRUMENTATIONS .
As of now, we can set this env value to AspNet,HttpClient,SqlClient but in the next release of the dotnet auto-instrumentation Npgsql, MySqlData will be added.
There was a problem hiding this comment.
We should definitely document this in the readme and the operator could set the variable (if it is not set) in the defaulting webhook
There was a problem hiding this comment.
Done. I have pushed the changes.
My bad. This file is not required. I will delete it and commit. |
* Adds support for dotnet auto-instrumentation * changes default image for testing * adds dotnet auto-instrumentation to the ldflags in makefile * changes in Makefile * fixes issue in makefile * fixes issue in dockerfile * passes dotnet sample app image to e2e test * fixes version in the dot net autoinstrumentation version file * adds testing changes for dot-net-autoinstrumentation * fixes annotation * downloads dot-net release from github * removes git push condition check * removes git push condition check * changes repo to logicmonitor * adds dontnet auto-instrumentation related details in readme * adds docker image layer caching in github action * triggers action on pull request * adds e2e test cases for dotnet instrumentation * fixes version for dotnet instrumentation * version changes * restores clusterversion file * restores changes in Makefile * minor change * Adds configuration details to dockerfile * updates version of dotnet auto-instrumentation * changes env var name from OTEL_DOTNET_TRACER_INSTRUMENTATIONS to OTEL_DOTNET_AUTO_TRACES_ENABLED_INSTRUMENTATIONS * removes java related env variables * fixes e2e test cases * fixes e2e test case * deletes .DS_Store file * sets OTEL_DOTNET_AUTO_TRACES_ENABLED_INSTRUMENTATIONS to default value * fixes e2e test case * fixes e2e test case
This PR adds a support for auto-instrumentation of the .Net applications.
Currently, dot net auto-instrumentation image is using the release opentelemetry-dotnet-instrumentation v0.2.0-beta.1.
Following environment variables are injected to the application container to enable the auto-instrumentation.
Resolves #756