Use OTEL collector image from GHCR #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frzifus
reviewed
Feb 22, 2022
| @@ -84,7 +84,7 @@ func main() { | |||
| pflag.BoolVar(&enableLeaderElection, "enable-leader-election", false, | |||
| "Enable leader election for controller manager. "+ | |||
| "Enabling this will ensure there is only one active controller manager.") | |||
| pflag.StringVar(&collectorImage, "collector-image", fmt.Sprintf("otel/opentelemetry-collector:%s", v.OpenTelemetryCollector), "The default OpenTelemetry collector image. This image is used when no image is specified in the CustomResource.") | |||
| pflag.StringVar(&collectorImage, "collector-image", fmt.Sprintf("ghcr.io/open-telemetry/opentelemetry-collector-releases/opentelemetry-collector:%s", v.OpenTelemetryCollector), "The default OpenTelemetry collector image. This image is used when no image is specified in the CustomResource.") | |||
There was a problem hiding this comment.
is it available?
i tried (podman/docker):
run --rm -it otel/opentelemetry-collector # worked
run --rm -it ghcr.io/open-telemetry/opentelemetry-collector-releases/opentelemetry-collector
Trying to pull ghcr.io/open-telemetry/opentelemetry-collector-releases/opentelemetry-collector:latest...
...
reading manifest latest in ghcr.io/open-telemetry/opentelemetry-collector-releases/opentelemetry-collector: manifest unknownThere was a problem hiding this comment.
There was a problem hiding this comment.
This PR should go in after #719
Signed-off-by: Pavol Loffay <[email protected]>
pavolloffay
force-pushed
the
collector-ghcr
branch
from
73aae4a to
df6409e
Compare
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
Signed-off-by: Pavol Loffay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pavol Loffay [email protected]
Depends on #719