Ensures that we only skip reconciliation for unmanaged resources #2197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
approved these changes
Oct 5, 2023
pavolloffay
approved these changes
Oct 6, 2023
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
…n-telemetry#2197) * ensures that we only skip reconciliation for unmanaged resources * update tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been reported a few times in slack and internally. You can read more in this slack thread. The TL;DR is that many users don't automatically upgrade the CRDs with helm when upgrading their operator. This results in a newer version of the operator working with an outdated CRD. When we introduced management state (#1888) we only checked if management state wasn't
managed. This meant that any users who weren't setting this field (or weren't being defaulted) would have an unmanaged otelcol to start with. This would be resolved by updating the CRD, but I want a more permanent operator fix hence this PR.