Replace maiigned by fieldalignment #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Israel Blancas <[email protected]>
Signed-off-by: Israel Blancas <[email protected]>
Signed-off-by: Israel Blancas <[email protected]>
Signed-off-by: Israel Blancas <[email protected]>
yuriolisa
reviewed
Jul 26, 2022
| and common container settings. Some fields are also present in container.securityContext. Field | ||
| values of container.securityContext take precedence over field values | ||
| of PodSecurityContext. | ||
| description: SecurityContext will be set as the container security |
There was a problem hiding this comment.
Which version did you use to create the bundle?
There was a problem hiding this comment.
Oh sorry! I found the problem (I though the change was expected but not). I used the fix option from fieldalignment and it removes the descriptions. I fixed some of them manually but it seems I broke others. Working on the fix.
Thanks for the feedback and sorry for the inconvenience :)
This reverts commit b49cf7a.
Signed-off-by: Israel Blancas <[email protected]>
pavolloffay
approved these changes
Jul 28, 2022
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Replace maiigned by fieldalignment Signed-off-by: Israel Blancas <[email protected]> * Disable unwanted linters Signed-off-by: Israel Blancas <[email protected]> * Apply changes requested by fieldalignment Signed-off-by: Israel Blancas <[email protected]> * Add autogenerated changes to the repository Signed-off-by: Israel Blancas <[email protected]> * Revert "Add autogenerated changes to the repository" This reverts commit b49cf7a. * Fix field descriptions Signed-off-by: Israel Blancas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Israel Blancas [email protected]
Fixes #987