Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lambda Layer update : Update Collector 0.51 #231

Merged
merged 5 commits into from
May 5, 2022
Merged

Lambda Layer update : Update Collector 0.51 #231

merged 5 commits into from
May 5, 2022

Conversation

vasireddy99
Copy link
Contributor

@vasireddy99 vasireddy99 commented Apr 5, 2022 •
edited
Loading

This PR upgrades the collector and collector contrib dependencies.

it includes the breaking changes in the OpenTelemetry-collector

Testing :

Testing is done by following these steps for collector extension

image

The command go mod tidy -go=1.17 is used to generate/update the go.sum file in top level opentelemtry-lambda/collector.

@vasireddy99 vasireddy99 changed the title Lambda Layer update : Update Collector 0.48 Lambda Layer update : Update Collector 0.49 Apr 21, 2022
@NathanielRN
Copy link
Contributor

Could you update the description to explain how you know these are the right changes? Usually collector changes a lot of APIs that break this repo 😅

@vasireddy99 vasireddy99 marked this pull request as draft April 28, 2022 19:46
@vasireddy99 vasireddy99 changed the title Lambda Layer update : Update Collector 0.49 Lambda Layer update : Update Collector 0.50 Apr 29, 2022
@vasireddy99 vasireddy99 force-pushed the updatecollector branch 2 times, most recently from 7b6ed0d to 7960fbe Compare May 2, 2022 04:34
@vasireddy99 vasireddy99 marked this pull request as ready for review May 2, 2022 05:13
@vasireddy99
Copy link
Contributor Author

Could you update the description to explain how you know these are the right changes? Usually collector changes a lot of APIs that break this repo 😅

Thanks Nathaniel, added test results

@vasireddy99 vasireddy99 force-pushed the updatecollector branch 2 times, most recently from 9e4123e to dd2a8d3 Compare May 5, 2022 22:49
NathanielRN
NathanielRN approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@NathanielRN NathanielRN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@NathanielRN NathanielRN merged commit 6d62225 into open-telemetry:main May 5, 2022
@vasireddy99 vasireddy99 deleted the updatecollector branch July 6, 2022 22:05
@vasireddy99 vasireddy99 changed the title Lambda Layer update : Update Collector 0.50 Lambda Layer update : Update Collector 0.51 Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanielRN NathanielRN NathanielRN approved these changes

@codeboten codeboten Awaiting requested review from codeboten

@wangzlei wangzlei Awaiting requested review from wangzlei

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vasireddy99 @NathanielRN