-
Notifications
You must be signed in to change notification settings - Fork 847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: prepare 2.0.0-dev.0/0.200.0-dev.0 release #5498
chore: prepare 2.0.0-dev.0/0.200.0-dev.0 release #5498
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5498 +/- ##
=======================================
Coverage 94.97% 94.97%
=======================================
Files 309 309
Lines 7958 7958
Branches 1692 1692
=======================================
Hits 7558 7558
Misses 400 400 |
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@opentelemetry/api-logs", | |||
"version": "0.57.0", | |||
"version": "0.200.0-dev.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: To make sure I understand this. Normally for a release, running the create-or-update-release-pr.yml
workflow would result in the package.json "version" fields being bumped, e.g. by npm run prepare_release:sdk:minor
. However, this PR will be used instead of the PR that would be created by running create-or-update-release-pr.yml
, right? In other words, the release version will actually be 0.200.0-dev.0
and not 0.201.0-dev.0
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly - we won't use the release script as we don't have one for major versions, and we're kind of doing a non-standard bump for the experimental packages.
I was briefly considering changing the release script, but I figured that since major releases will only happen once a year then it's not something that's worth automating. :)
FYI for anyone interested:
|
Which problem is this PR solving?
Important
There was some manual work involved in bumping the versions as I cannot just let lerna do everything (0.x/2.x split does not lend it self well to
lerna version <something>
)review this not as an auto-generated PR but as a PR made by a human - I have double-checked but still there may be inconsistencies.
This bumps the versions to
2.0.0-dev.0
/0.200.0-dev.0
- I choosedev.0
for now, we may do more prereleases later (alpha
,beta
,rc
).Note: this does not bump the version for
@opentelemetry/api
/@opentelemetry/semantic-conventions
so they won't be released, only the other packages will be published when I run the worklfowThis PR requires #5496 to be merged first to avoid accidentally getting the
latest
dist-tag on release frommain
Refs #5497
How Has This Been Tested?