Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare 2.0.0-dev.0/0.200.0-dev.0 release #5498

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Feb 20, 2025

Which problem is this PR solving?

Important

There was some manual work involved in bumping the versions as I cannot just let lerna do everything (0.x/2.x split does not lend it self well to lerna version <something>)

review this not as an auto-generated PR but as a PR made by a human - I have double-checked but still there may be inconsistencies.

This bumps the versions to 2.0.0-dev.0/0.200.0-dev.0 - I choose dev.0 for now, we may do more prereleases later (alpha, beta, rc).

Note: this does not bump the version for @opentelemetry/api/@opentelemetry/semantic-conventions so they won't be released, only the other packages will be published when I run the worklfow

This PR requires #5496 to be merged first to avoid accidentally getting the latest dist-tag on release from main

Refs #5497

How Has This Been Tested?

  • Unit tests

@pichlermarc pichlermarc changed the title chore: prepare 2.0.0-dev.0/0.200.0 release chore: prepare 2.0.0-dev.0/0.200.0-dev.0 release Feb 20, 2025
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.97%. Comparing base (492ed35) to head (05ae354).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5498   +/-   ##
=======================================
  Coverage   94.97%   94.97%           
=======================================
  Files         309      309           
  Lines        7958     7958           
  Branches     1692     1692           
=======================================
  Hits         7558     7558           
  Misses        400      400           

@pichlermarc pichlermarc added this to the OpenTelemetry SDK 2.0 milestone Feb 20, 2025
@pichlermarc pichlermarc added the target:next-major-release This PR targets the next major release (`next` branch) label Feb 20, 2025
@pichlermarc pichlermarc marked this pull request as ready for review February 20, 2025 16:13
@pichlermarc pichlermarc requested a review from a team as a code owner February 20, 2025 16:13
@@ -1,6 +1,6 @@
{
"name": "@opentelemetry/api-logs",
"version": "0.57.0",
"version": "0.200.0-dev.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: To make sure I understand this. Normally for a release, running the create-or-update-release-pr.yml workflow would result in the package.json "version" fields being bumped, e.g. by npm run prepare_release:sdk:minor. However, this PR will be used instead of the PR that would be created by running create-or-update-release-pr.yml, right? In other words, the release version will actually be 0.200.0-dev.0 and not 0.201.0-dev.0.

Copy link
Member Author

@pichlermarc pichlermarc Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly - we won't use the release script as we don't have one for major versions, and we're kind of doing a non-standard bump for the experimental packages.

I was briefly considering changing the release script, but I figured that since major releases will only happen once a year then it's not something that's worth automating. :)

@pichlermarc pichlermarc added this pull request to the merge queue Feb 21, 2025
@pichlermarc
Copy link
Member Author

FYI for anyone interested:

  • I'm merging this now, but the release won't happen automatically
  • We can decide ourselves when to release this by running the publish workflow now that the versions are bumped.

Merged via the queue into open-telemetry:main with commit 2053f0d Feb 21, 2025
19 checks passed
@pichlermarc pichlermarc deleted the chore/prepare-2x-prerelease branch February 21, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog target:next-major-release This PR targets the next major release (`next` branch)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants