feat(resources)!: do not read environment variables from window #5466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pichlermarc
force-pushed
the
feat/migrate-from-getenv-resources
branch
from
8255f87 to
b0cbbe0
Compare
pichlermarc
changed the title
pichlermarc
force-pushed
the
feat/migrate-from-getenv-resources
branch
from
1ff2e02 to
b100bd6
Compare
pichlermarc
changed the title
pichlermarc
changed the title
pichlermarc
added
the
target:next-major-release
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5466 +/- ##
==========================================
- Coverage 94.90% 94.90% -0.01%
==========================================
Files 308 308
Lines 7975 7974 -1
Branches 1677 1677
==========================================
- Hits 7569 7568 -1
Misses 406 406
|
pichlermarc
force-pushed
the
feat/migrate-from-getenv-resources
branch
from
54e1a1c to
b100bd6
Compare
maryliag
reviewed
Feb 13, 2025
| }); | ||
| }); | ||
|
|
||
| describe('with invalid env', () => { |
There was a problem hiding this comment.
with the new method is no longer possible to have invalid values?
or doesn't matter because it returns the empty and you're already testing that below?
There was a problem hiding this comment.
These are the browser tests that before this PR allowed for users to set window.OTEL_SERVICE_NAME. Now on the browser this will always return an empty resource, as the new functions always return undefined in the browser.
That means that the EnvDetector is now a no-op detector for Browsers, hence no need to test many inputs anymore. 🙂
maryliag
approved these changes
Feb 13, 2025
4 tasks
trentm
pushed a commit
to trentm/opentelemetry-js
that referenced
this pull request
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Migrates from
getEnv()to using the newget*FromEnv()methods added in #5443. Also inlines the defaults. This drops "env var configuration" (viawindow.OTEL_*) in browser environments.This breaking change will basically make the
EnvDetectora no-op detector for browser environments.Refs #5217
Type of change
How Has This Been Tested?