refactor(instrumentation-grpc): fix eslint warnings #5408
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes the following eslint warnings in the instrumentation-grpc package:
Ref #5365
Short description of the changes
This commit does not involve any changes to runtime code and can be safely merged without any concerns about changing behavior.
The first can be replaced with the more precise type that we are expecting.
The second just wansn't needed anymore.
The third is highly unusual. After spending significant amount of time reading and stepping through the code – I am quite confident that the
.call({}, ...)
(and.apply({}, ...)
elsewhere in the tests) are a mistake that we inherited from very old code. However I don't feel confident enough that I can explain what is going on here to make a change to the runtime code, so in the meantime, I think the best course of action is to leave it as-is, document the issue and have someone with more expertise untangle this down the road.The last one was a change in test code to use a more precise call signature.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: