refactor(sdk-node): fix eslint warning #5400
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5400 +/- ##
=======================================
Coverage 94.63% 94.63%
=======================================
Files 318 318
Lines 8032 8032
Branches 1685 1685
=======================================
Hits 7601 7601
Misses 431 431 |
``` /home/runner/work/opentelemetry-js/opentelemetry-js/experimental/packages/opentelemetry-sdk-node/src/index.ts 20:1 warning Using 'ExportAllDeclaration' is not allowed no-restricted-syntax 21:1 warning Using 'ExportAllDeclaration' is not allowed no-restricted-syntax 22:1 warning Using 'ExportAllDeclaration' is not allowed no-restricted-syntax 23:1 warning Using 'ExportAllDeclaration' is not allowed no-restricted-syntax 24:1 warning Using 'ExportAllDeclaration' is not allowed no-restricted-syntax 25:1 warning Using 'ExportAllDeclaration' is not allowed no-restricted-syntax 26:1 warning Using 'ExportAllDeclaration' is not allowed no-restricted-syntax 27:1 warning Using 'ExportAllDeclaration' is not allowed no-restricted-syntax ``` This feels a bit different than the other ones, as this is a meta- package, and these are wildcard exports to re-export all the public exports from the upstream packages into individual _namespaces_. There is no risk of accidentally exporting something that wasn't meant to be public, and it would be a huge pain to enumerate things from each of the upstream packages and keep things in-sync. Ref open-telemetry#5365
chancancode
force-pushed
the
eslint-warning-sdk-node
branch
from
926e20c to
267e8b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes the following eslint warnings from the sdk-node package:
Ref #5365
Short description of the changes
This feels a bit different than the other ones (#5399), as this is a meta- package, and these are wildcard exports to re-export all the public exports from the upstream packages into individual namespaces.
There is no risk of accidentally exporting something that wasn't meant to be public, and it would be a huge pain to enumerate things from each of the upstream packages and keep things in-sync.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: