Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http server semconv span stable #4978

Merged
Changes from 1 commit
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
c5f4b41
feat(instr-http): emit stable semconv for client spans
dyladan Aug 21, 2024
3d1b95d
Document OTEL_SEMCONV_STABILITY_OPT_IN for http
dyladan Aug 21, 2024
d978eb1
Lint
dyladan Aug 21, 2024
963e19a
Merge remote-tracking branch 'origin/main' into http-client-semconv-s…
dyladan Aug 22, 2024
dc75e57
Fix build
dyladan Aug 22, 2024
c71cdb0
Changelog
dyladan Aug 22, 2024
eae1d5c
lint
dyladan Aug 22, 2024
f7efbe8
Add tests for 1.27 semconv
dyladan Aug 23, 2024
2d60245
Merge remote-tracking branch 'origin/main' into http-client-semconv-s…
dyladan Aug 23, 2024
5031276
Use actual remote address for tests
dyladan Aug 23, 2024
10e49f1
Apply fix to stable spans
dyladan Aug 23, 2024
e4a36b1
Merge branch 'main' into http-client-semconv-span-stable
dyladan Aug 28, 2024
9b5ae5b
Update experimental/packages/opentelemetry-instrumentation-http/src/u…
dyladan Sep 4, 2024
83b91f0
chore(deps): update dependency chromedriver to v128 (#4954)
renovate-bot Aug 28, 2024
61f344d
chore(deps): update dependency webpack to v5.94.0 (#4961)
pichlermarc Aug 28, 2024
362a1bc
chore(deps): update dependency glob to v11 (#4955)
renovate-bot Aug 28, 2024
9e2485d
chore(deps): update all patch versions (#4942)
renovate-bot Aug 28, 2024
08c5a9a
chore(deps): update dependency chromedriver to v128.0.1 (#4967)
renovate-bot Sep 2, 2024
4920848
chore(deps): lock file maintenance (#4968)
renovate-bot Sep 2, 2024
93d43ce
Finish transition plan in readme
dyladan Sep 4, 2024
e725146
Review comments
dyladan Sep 4, 2024
0635448
Await server.listen in before to be sure it finishes
dyladan Sep 4, 2024
253c840
Lint
dyladan Sep 4, 2024
2533480
Merge remote-tracking branch 'origin/main' into http-client-semconv-s…
dyladan Sep 4, 2024
e4ccec8
Changelog
dyladan Sep 4, 2024
1bdce0f
Merge remote-tracking branch 'origin/main' into http-client-semconv-s…
dyladan Sep 4, 2024
1c9abb5
Update http server semconv to 1.27
dyladan Sep 4, 2024
9a0c2de
Add server to readme
dyladan Sep 4, 2024
3703045
Lint
dyladan Sep 4, 2024
397ebc6
Fix compilation and test
dyladan Sep 5, 2024
98e02f5
Merge remote-tracking branch 'origin/main' into http-server-semconv-s…
dyladan Sep 11, 2024
7addab4
Fix changelog
dyladan Sep 11, 2024
12d0489
Add tests for server spans
dyladan Sep 11, 2024
4c19670
Lint
dyladan Sep 11, 2024
1054a44
Changelog
dyladan Sep 11, 2024
966eaa5
Change address for tests
dyladan Sep 11, 2024
090f394
Fix node 14 tests
dyladan Sep 11, 2024
46a42e0
remove console
dyladan Sep 11, 2024
826e79b
Add a more detailed changelog
dyladan Sep 17, 2024
0df46dd
Normalize request methods
dyladan Sep 17, 2024
01b90c5
Only set attributes if they are collected
dyladan Sep 17, 2024
bc4d955
More robust host header parsing
dyladan Sep 17, 2024
52c10d4
Lint
dyladan Sep 17, 2024
8a02c47
Merge remote-tracking branch 'origin/main' into http-server-semconv-s…
dyladan Sep 17, 2024
6354a8f
Lint eqeqeq
dyladan Sep 17, 2024
c9df445
Merge branch 'main' into http-server-semconv-span-stable
dyladan Sep 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Lint
  • Loading branch information
dyladan committed Sep 4, 2024
commit 253c8401c6ac832a78df9ae1cecb7d43bc3bf7cf
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ export const setRequestContentLengthAttribute = (
* Adds attributes for response content-length and content-encoding HTTP headers
* @param { IncomingMessage } Response object whose headers will be analyzed
* @param { SpanAttributes } SpanAttributes object to be modified
*
*
* @deprecated this is for an older version of semconv. It is retained for compatibility using OTEL_SEMCONV_STABILITY_OPT_IN
*/
export const setResponseContentLengthAttribute = (
Expand Down Expand Up @@ -416,7 +416,7 @@ export const getOutgoingRequestAttributes = (
// leaving out protocol version, it is not yet negotiated
// leaving out protocol name, it is only required when protocol version is set
// retries and redirects not supported

// Opt-in attributes left off for now
};

Expand Down