Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(opentelemetry-browser-detector): Use tree-shakeable string constants for semconv in Readme #4768

Merged
merged 8 commits into from
Jul 5, 2024
2 changes: 2 additions & 0 deletions experimental/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ All notable changes to experimental packages in this project will be documented

### :books: (Refine Doc)

* docs(opentelemetry-browser-detector): Use tree-shakeable string constants for semconv in Readme [#4768](https://github.com/open-telemetry/opentelemetry-js/pull/4768) @JohannesHuster

### :house: (Internal)

* test: add `npm run maint:regenerate-test-certs` maintenance script and regenerate recently expired test certs [#4777](https://github.com/open-telemetry/opentelemetry-js/pull/4777)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@ npm install --save @opentelemetry/opentelemetry-browser-detector

```js
import { Resource, detectResources } from '@opentelemetry/resources';
import { SemanticResourceAttributes } from '@opentelemetry/semantic-conventions';
import { SEMRESATTRS_SERVICE_NAME } from '@opentelemetry/semantic-conventions';
import { browserDetector } from '@opentelemetry/opentelemetry-browser-detector';

async function start(){
let resource= new Resource({
[SemanticResourceAttributes.SERVICE_NAME]: 'Test App Name',
[SEMRESATTRS_SERVICE_NAME]: 'Test App Name',
});
let detectedResources= await detectResources({detectors:[browserDetector]});
resource=resource.merge(detectedResources);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,7 @@
"@opentelemetry/api": "^1.0.0"
},
"dependencies": {
"@opentelemetry/resources": "1.25.0",
"@opentelemetry/semantic-conventions": "1.25.0"
"@opentelemetry/resources": "1.25.0"
},
"homepage": "https://github.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/browser-detector"
}
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@
},
{
"path": "../../../packages/opentelemetry-resources"
},
{
"path": "../../../packages/opentelemetry-semantic-conventions"
}
]
}
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@
},
{
"path": "../../../packages/opentelemetry-resources"
},
{
"path": "../../../packages/opentelemetry-semantic-conventions"
}
]
}
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@
},
{
"path": "../../../packages/opentelemetry-resources"
},
{
"path": "../../../packages/opentelemetry-semantic-conventions"
}
]
}
4 changes: 1 addition & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.