chore: move flarna from approver to emeritus #4757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4757 +/- ##
==========================================
+ Coverage 91.04% 93.84% +2.80%
==========================================
Files 89 240 +151
Lines 1954 5606 +3652
Branches 416 1125 +709
==========================================
+ Hits 1779 5261 +3482
- Misses 175 345 +170 |
JamieDanielson
approved these changes
Jun 4, 2024
pichlermarc
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Thank you for your work on the project. Glad to hear that you'll still be around even if not in an approver-role.
Your feedback is always very valuable and I know that many others see it the same way 🙂
Edit: I updated the @open-telemetry/javascript-approvers team accordingly.
Merged
via the queue into
open-telemetry:main
with commit Jun 5, 2024
9d3bc18
21 of 22 checks passed
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@open-telemetry/javascript-maintainers Please adapt the needed rights/groups/.... accordingly.
I'm still around but as of now I don't find enough time to really follow the project in the needed details to really fulfill the approver role.