Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove handling of node versions 8, 9 and 10 in tests #3696

Merged
merged 3 commits into from
Mar 28, 2023

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Mar 22, 2023

Which problem is this PR solving?

Extracted from #3689.

Fixes # N/A

Short description of the changes

CI only runs on Node 14+, so this is dead code

Type of change

Housekeeping

How Has This Been Tested?

CI

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@SimenB SimenB requested a review from a team March 22, 2023 08:17
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #3696 (b25db6e) into main (dbe005f) will decrease coverage by 0.05%.
The diff coverage is 75.00%.

❗ Current head b25db6e differs from pull request most recent head a7992d0. Consider uploading reports for the commit a7992d0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3696      +/-   ##
==========================================
- Coverage   93.70%   93.65%   -0.05%     
==========================================
  Files         277      277              
  Lines        8446     8462      +16     
  Branches     1753     1756       +3     
==========================================
+ Hits         7914     7925      +11     
- Misses        532      537       +5     
Impacted Files Coverage Δ
...tal/packages/otlp-transformer/src/metrics/types.ts 100.00% <ø> (ø)
packages/sdk-metrics/src/view/Aggregation.ts 93.82% <55.55%> (-4.79%) ⬇️
.../packages/otlp-transformer/src/metrics/internal.ts 98.00% <100.00%> (+0.27%) ⬆️
packages/sdk-metrics/src/aggregator/index.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@SimenB
Copy link
Contributor Author

SimenB commented Mar 24, 2023

weird that CI is failing here but green on main - I haven't changed the failing files

@Flarna
Copy link
Member

Flarna commented Mar 24, 2023

similar fails seen in #3699

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants