Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: split test script into test/test:coverage #3633
chore: split test script into test/test:coverage #3633
Changes from 2 commits
63f1fd7
261e0e6
9507695
789aa5b
0e23125
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I "like" having the test coverage when compiling locally as a guide to what I'm missing....
eg. My preference would be to flip these around
test
=> full test run (with coverage)test:no-coverage
=> just run the testsBut I may just be a bit weird 🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I may be the weird one having different workflow than most, as I'm running JetBrains WebStorm as an IDE. It may make sense to flip it around. 🙂
pinging @open-telemetry/javascript-approvers, wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we run the coverage by default when a single package is tested, but no coverage by default when all packages are tested? I doubt anyone is looking through coverage information when they test all 36 packages.
/package.json
somepackage/package.json