chore: improve windows compatibility of update-ts-config #3475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change update-ts-config script to generate posix path also on windows to avoid that tsconfig.json files are wrongly modified.
Flarna
force-pushed
the
update-ts-config-win
branch
from
2622466 to
1f869bd
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3475 +/- ##
==========================================
+ Coverage 93.68% 93.76% +0.07%
==========================================
Files 247 248 +1
Lines 7537 7566 +29
Branches 1575 1580 +5
==========================================
+ Hits 7061 7094 +33
+ Misses 476 472 -4
|
naseemkullah
approved these changes
Dec 7, 2022
Flarna
changed the title
legendecas
approved these changes
Dec 7, 2022
| writeJSON(tsconfigPath, tsconfig, dryRun); | ||
|
|
||
| for (const tsconfigName of ['tsconfig.esm.json', 'tsconfig.esnext.json']) { | ||
| const tsconfigPath = path.join(pkgRoot, tsconfigName); | ||
| const tsconfig = readJSON(tsconfigPath); | ||
| const references = Array.from(lernaProjects.values()) | ||
| .filter(it => it.isTsProject && it.hasMultiTarget) | ||
| .map(it => path.relative(pkgRoot, path.join(projectRoot, it.dir))).sort(); | ||
| .map(it => toPosix(path.relative(pkgRoot, path.join(projectRoot, it.dir)))).sort(); |
There was a problem hiding this comment.
Duplicated with line 119.
Suggested change
| .map(it => toPosix(path.relative(pkgRoot, path.join(projectRoot, it.dir)))).sort(); | |
| .map(it => path.relative(pkgRoot, path.join(projectRoot, it.dir))).sort(); |
There was a problem hiding this comment.
to late - @dyladan merged already...
| @@ -99,23 +100,23 @@ function writeRootTsConfigJson(pkgRoot, projectRoot, lernaProjects) { | |||
| const tsconfig = readJSON(tsconfigPath); | |||
| const references = Array.from(lernaProjects.values()) | |||
| .filter(it => it.isTsProject) | |||
| .map(it => path.relative(pkgRoot, path.join(projectRoot, it.dir))).sort(); | |||
| .map(it => toPosix(path.relative(pkgRoot, path.join(projectRoot, it.dir)))).sort(); | |||
There was a problem hiding this comment.
Duplicated with line 105:
Suggested change
| .map(it => toPosix(path.relative(pkgRoot, path.join(projectRoot, it.dir)))).sort(); | |
| .map(it => path.relative(pkgRoot, path.join(projectRoot, it.dir))).sort(); |
dyladan
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change update-ts-config script to generate posix path also on windows to avoid that tsconfig.json files are wrongly modified.