Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't let PeriodicExportingMetricReader block process exit #3106

Merged
merged 2 commits into from
Jul 23, 2022

Conversation

seemk
Copy link
Contributor

@seemk seemk commented Jul 21, 2022

PeriodicExportingMetricReader currently keeps the Node.js process from exiting when not doing an explicit shutdown.

@seemk seemk requested a review from a team July 21, 2022 17:23
@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #3106 (50abeae) into main (1a0e0c4) will decrease coverage by 1.09%.
The diff coverage is n/a.

❗ Current head 50abeae differs from pull request most recent head 35499ec. Consider uploading reports for the commit 35499ec to get more accurate results

@@            Coverage Diff             @@
##             main    #3106      +/-   ##
==========================================
- Coverage   93.08%   91.98%   -1.10%     
==========================================
  Files         188       82     -106     
  Lines        6243     2407    -3836     
  Branches     1313      522     -791     
==========================================
- Hits         5811     2214    -3597     
+ Misses        432      193     -239     
Impacted Files Coverage Δ
packages/opentelemetry-resources/karma.worker.js 0.00% <0.00%> (-100.00%) ⬇️
...s/opentelemetry-core/src/platform/node/sdk-info.ts 0.00% <0.00%> (-100.00%) ⬇️
...opentelemetry-core/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) ⬇️
...pentelemetry-core/src/platform/node/performance.ts 0.00% <0.00%> (-100.00%) ⬇️
...emetry-api-metrics/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) ⬇️
...lemetry-resources/src/detectors/ProcessDetector.ts 31.81% <0.00%> (-68.19%) ⬇️
...perimental/packages/otlp-exporter-base/src/util.ts 79.41% <0.00%> (-17.65%) ⬇️
...ckages/opentelemetry-exporter-zipkin/src/zipkin.ts 84.48% <0.00%> (-15.52%) ⬇️
...lemetry-resources/src/detectors/BrowserDetector.ts 93.33% <0.00%> (-6.67%) ⬇️
...s-base/src/export/PeriodicExportingMetricReader.ts
... and 105 more

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for adding this! 🙂

@vmarchaud vmarchaud merged commit d5cf120 into open-telemetry:main Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants