Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(eslint): remove airbnb package #2955

Merged
merged 3 commits into from
May 12, 2022

Conversation

Ugzuzg
Copy link
Contributor

@Ugzuzg Ugzuzg commented May 7, 2022

Which problem is this PR solving?

Remove eslint-config-airbnb-base dependency

Fixes #2922

Short description of the changes

Clean up the repo from leftover airbnb rules. Also removes the import plugin as it was only used by airbnb plugin. Relies on configuration cascading.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

npm run lint works without any issues.

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@Ugzuzg Ugzuzg requested a review from a team May 7, 2022 10:20
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 7, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Ugzuzg / name: Jaryk (5ba26dd)

@codecov
Copy link

codecov bot commented May 7, 2022

Codecov Report

Merging #2955 (d8e1fb2) into main (269a495) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2955   +/-   ##
=======================================
  Coverage   92.51%   92.51%           
=======================================
  Files         183      183           
  Lines        5959     5959           
  Branches     1266     1266           
=======================================
  Hits         5513     5513           
  Misses        446      446           

@Ugzuzg Ugzuzg force-pushed the chore/remove-airbnb branch from d2e3a90 to 61772c2 Compare May 11, 2022 13:38
@legendecas legendecas merged commit 65fbb2f into open-telemetry:main May 12, 2022
@Ugzuzg Ugzuzg deleted the chore/remove-airbnb branch May 12, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove eslint-config-airbnb-base dependency
3 participants