Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix compilation errors #2614

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Nov 11, 2021

Now that the core dependencies have been updated, remove the @ts-ignore directives. They are actually causing the build to fail now as can be seen here: https://github.com/open-telemetry/opentelemetry-js/runs/4179375965?check_suite_focus=true

@dyladan dyladan requested a review from a team November 11, 2021 15:06
@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #2614 (31b0dd7) into main (9cf402e) will decrease coverage by 0.97%.
The diff coverage is n/a.

❗ Current head 31b0dd7 differs from pull request most recent head f5e227f. Consider uploading reports for the commit f5e227f to get more accurate results

@@            Coverage Diff             @@
##             main    #2614      +/-   ##
==========================================
- Coverage   94.02%   93.04%   -0.98%     
==========================================
  Files          76      138      +62     
  Lines        2409     5093    +2684     
  Branches      549     1096     +547     
==========================================
+ Hits         2265     4739    +2474     
- Misses        144      354     +210     
Impacted Files Coverage Δ
...metry-sdk-metrics-base/src/ObservableBaseMetric.ts 90.90% <0.00%> (ø)
...s/opentelemetry-instrumentation-fetch/src/fetch.ts 96.98% <0.00%> (ø)
...pentelemetry-sdk-metrics-base/src/MeterProvider.ts 88.57% <0.00%> (ø)
...y-instrumentation-grpc/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...strumentation/src/platform/node/instrumentation.ts 60.25% <0.00%> (ø)
...kages/opentelemetry-api-metrics/src/api/metrics.ts 90.90% <0.00%> (ø)
...es/opentelemetry-instrumentation/src/autoLoader.ts 100.00% <0.00%> (ø)
...ackages/opentelemetry-api-metrics/src/NoopMeter.ts 79.48% <0.00%> (ø)
...y-instrumentation-http/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...emetry-instrumentation-xml-http-request/src/xhr.ts 97.58% <0.00%> (ø)
... and 52 more

@legendecas
Copy link
Member

this is how @ts-expect-error reminds us to remove it timely.

@dyladan dyladan merged commit 0bc25fa into open-telemetry:main Nov 11, 2021
@dyladan dyladan deleted the compilation-errors branch November 11, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants